Update project to Swift 5.10 and start on Sendable updates
#833
Conversation
| @@ -259,7 +259,7 @@ extension XCBuildConfiguration { | |||
| /// :nodoc: | |||
| func isEqual(to rhs: XCBuildConfiguration) -> Bool { | |||
| if baseConfigurationReference != rhs.baseConfigurationReference { return false } | |||
| if !NSDictionary(dictionary: buildSettings).isEqual(NSDictionary(dictionary: rhs.buildSettings)) { return false } | |||
| if buildSettings != rhs.buildSettings { return false } | |||
There was a problem hiding this comment.
I wasnt able to find info on how to run Sourcery to do generate this, but this makes tests pass. Happy to make sure the generated code is correct but will need an assist on running things.
There was a problem hiding this comment.
I think it's ok. Let's make those changes manually.
There was a problem hiding this comment.
Amazing job @waltflanagan. Regarding the APIs to obtain the objects referenced by the PBXObjectReference, feel free to tackle that in a separate PR.
|
|
||
| // QUESTION: this is exposed to the project but so is `getThrowingObject` and `getObject`. What access patterns do we want to support? |
There was a problem hiding this comment.
Good point. I think having three APIs for the same is unnecessary. I believe (it's been a long time) that the motivation for having getThrowingObject was to instruct developers at runtime about bad usages of the library. For example adding a reference to an object that's not strongly referenced by the project. However, looking at the getThrowingObject implementation, and don't know if the error that we are throwing is more helpful than trying to do a force unwrap of the referenced object.
I'm between making getThrowingObject errors more useful, which would require adding more context to PBXObjectReference to ensure it's in sync, which is a bit of a tricky challenge, or removing getObject and getThrowingObject and having a single accessor. I'd say that we do the latter.
There was a problem hiding this comment.
I ended up going with object() -> T? since that preserved the most current callsites. Also added object(as: T.Type) to avoid a double cast when used in compactMap
| @@ -259,7 +259,7 @@ extension XCBuildConfiguration { | |||
| /// :nodoc: | |||
| func isEqual(to rhs: XCBuildConfiguration) -> Bool { | |||
| if baseConfigurationReference != rhs.baseConfigurationReference { return false } | |||
| if !NSDictionary(dictionary: buildSettings).isEqual(NSDictionary(dictionary: rhs.buildSettings)) { return false } | |||
| if buildSettings != rhs.buildSettings { return false } | |||
There was a problem hiding this comment.
I think it's ok. Let's make those changes manually.
No description provided.